Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis Build #1076

Merged
merged 10 commits into from
Nov 7, 2019
Merged

Fix Travis Build #1076

merged 10 commits into from
Nov 7, 2019

Conversation

keefertaylor
Copy link
Contributor

Changes:

Notes

To get Travis building, the toggles for Push and Pulled builds need to get turned on in the Travis Settings Panel.

I have permissions to do this, but wanted to check with a library owner before I messed with settings. Let me know if I should make it so. Once this happens, I can tickle the build request here.

@keefertaylor keefertaylor changed the title Enable Travis Building Fix Travis Build Nov 3, 2019
Copy link
Collaborator

@intelliot intelliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I’ll try this out tomorrow

Copy link
Collaborator

@intelliot intelliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good. How about doing Squash and merge just so our commit history is cleaner?

@intelliot intelliot merged commit 5c84eed into XRPLF:develop Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants