Assign event listener to socket close event on open before attempting post-open logic #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to execute post-connection logic, prottects possible unhandled rejection in disconnect
0xCLARITY
reviewed
Jan 24, 2020
There was a problem hiding this comment.
I'm not that familiar with this code / WebSockets, so I'm going to see if I understand the problem here.
We handle cleanup in the _ws.close event listener. However, previously we were setting up the _ws.close listener too late, and we were getting an error after opening the connection, but before setting up the _ws.close event listener responsible for cleanup.
That would result in subsequent reconnection errors, because we had failed to clean up before. Is that all correct?
nickewansmith
requested review from
FKSRipple
and removed request for
intelliot and
FKSRipple
FredKSchott
reviewed
Jan 24, 2020
intelliot
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the Connection
_ws.closeevent listener post_ws.openbefore executing any post_ws.openlogic, i.e.Connection._subscribeToLedger. This prevents a reconnection error loop that occurs ifConnection._wsis never cleaned up by the unreachable_ws.closeevent listener. Also, this ensures that a possible disconnect() promise rejection is not unhandled if any_ws.openlogic inConnection.connect()throws.