-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update getNFTokenID to properly handle binary blob #2247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckniffen
approved these changes
Mar 28, 2023
ckniffen
reviewed
Mar 28, 2023
mvadari
reviewed
Mar 28, 2023
mvadari
reviewed
Mar 28, 2023
This PR needs to be rebased before it can be reviewed |
I may not get to this for a bit, working on other things which have to be completed this week. Will ping again once this PR is ready to actually be reviewed. |
JST5000
force-pushed
the
update-get-nftokenid
branch
from
May 25, 2023 20:16
86f3075
to
e514dc5
Compare
ckniffen
approved these changes
May 25, 2023
mvadari
reviewed
May 25, 2023
mvadari
reviewed
Jun 5, 2023
mvadari
reviewed
Jun 8, 2023
mvadari
reviewed
Jun 9, 2023
mvadari
approved these changes
Jun 14, 2023
@JST5000 please fix merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Update
getNFTokenID
to allow for binary blobs since that's a valid return from atx
request.Context of Change
When updating this test to work with the new standalone container, I realized that I had misunderstood the return type and it was more complicated than just the
meta
in JSON format.Must be merged in after #2223 as it relies on that docker container for tests.
Type of Change
Before / After
Test Plan
CI Passes