Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose LedgerEntry singletons #2358

Merged
merged 6 commits into from
Jul 3, 2023
Merged

Conversation

ckniffen
Copy link
Collaborator

High Level Overview of Change

Add an id for NegativeUNL and Amendments which are singleton objects.

Type of Change

  • New feature (non-breaking change which adds functionality)

Adds the new fields for `XRPFees` amendment and id for the `FeeSettings`
singleton ledger entry.

Closes #2219
Add an id for `NegativeUNL` and `Amendments` which are singleton objects
Base automatically changed from feature/XRPFees to main June 29, 2023 21:27
@intelliot
Copy link
Collaborator

Can we link to something in the docs or in rippled that indicates how these values are generated?

@ckniffen
Copy link
Collaborator Author

ckniffen commented Jul 1, 2023

Can we link to something in the docs or in rippled that indicates how these values are generated?

I can link to where in the docs they are stated.

@ckniffen ckniffen merged commit 5925ad2 into main Jul 3, 2023
17 checks passed
@ckniffen ckniffen deleted the feature/ledger-entry-singletons branch July 3, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants