feat(types): Export most of the types #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose most of the types in the `xrpl` package. Some renames will only affect you if you were deep importing these types previously. Renames of deep importable types: - `methods/bookOffers`: `TakerAmount` -> `BookOfferCurrency` - `methods/accountLines`: `Trustline` -> `AccountLinesTrustline`
justinr1234
approved these changes
Jul 1, 2023
JST5000
reviewed
Jul 3, 2023
| } | ||
|
|
||
| export interface NFTokenPage extends BaseLedgerEntry { | ||
| LedgerEntryType: 'NFTokenPage' | ||
| NextPageMin?: string | ||
| NFTokens: NFTokenWrapper[] | ||
| NFTokens: NFToken[] |
There was a problem hiding this comment.
Why was this changed from NFTokenWrapper?
There was a problem hiding this comment.
To keep it inline with the other nested STObjects in STArrays. After looking at more definitions i decided to change it. NFTokenWrapper was never in a released version of xrpl.js so figured now would be a good time to change it.
khancode
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Expose most of the types in the
xrplpackage.BREAKING CHANGE: Renames of deep importable types:
methods/accountLines:Trustline->AccountLinesTrustlinemethods/bookOffers:TakerAmount->BookOfferCurrencymethods/ledgerData:BinaryLedgerEntry->LedgerDataBinaryLedgerEntryType of Change