Enable the removal of a signer list #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signerquorum field has to be 0 and the signerentires field has to be undefined
ckniffen
reviewed
Jul 12, 2023
|
|
||
| // Remove signerlist | ||
| it( | ||
| 'base', |
There was a problem hiding this comment.
Please rename the test to something else.
|
The |
ckniffen
approved these changes
Jul 12, 2023
JST5000
approved these changes
Jul 12, 2023
dangell7
pushed a commit
to Transia-RnD/xrpl.js
that referenced
this pull request
Jul 19, 2023
`SignerQuorum` field has to be 0 and the `SignerEntrys` field has to be `undefined` Co-authored-by: Caleb Kniffen <ckniffen@ripple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signerquorum field has to be 0 and the signerentires field has to be undefined
High Level Overview of Change
Context of Change
Type of Change
Test Plan