feat: add support for XLS-40d + add script to auto-generate models from rippled code #2491
Conversation
| ) | ||
|
|
||
| newJsTxFile = newJsTxFile.replace( | ||
| `import { |
There was a problem hiding this comment.
This feels oddly specific to one type.
There was a problem hiding this comment.
It's the last type in the list, it was easier to do it this way and have the linter fix the sorting than do some complex regex that sorts alphabetically.
There was a problem hiding this comment.
Can you add a comment with that context?
| @@ -140,40 +141,40 @@ | |||
| [ | |||
| "LedgerEntry", | |||
| { | |||
| "nth": 1, | |||
| "nth": 257, | |||
There was a problem hiding this comment.
Why did these fields change?
There was a problem hiding this comment.
Fixing discrepancies between the server_definitions RPC and the xrpl-codec-gen script. Tests all pass because these fields aren't used for signing, they only exist for rippled technical reasons.
| | AMMVote | ||
| | AMMWithdraw | ||
| | AccountDelete | ||
| | AccountSet |
There was a problem hiding this comment.
nit: Alphabetically AccountDelete and AccountSet should be before AMM...
There was a problem hiding this comment.
(Same nit applies below with the case statement if we want to maintain alphabetical order)
There was a problem hiding this comment.
I was sorting with capitals before lowercase, which makes more sense to me, but if you disagree I'm happy to change that.
There was a problem hiding this comment.
I personally don't consider capitalization when scanning lists, so I'd prefer to ignore it when sorting alphabetically
| Flags: 2147483648, | ||
| Sequence: 4, | ||
| TransactionType: 'DIDDelete', | ||
| } as any |
There was a problem hiding this comment.
Why is typed as any instead of DIDDelete?
There was a problem hiding this comment.
So that you can remove required fields without TS complaining (see other model tests)
High Level Overview of Change
This PR adds support for XLS-40 and adds a script to automatically generate transaction models from rippled source code.
Context of Change
XRPLF/XRPL-Standards#136
XRPLF/rippled#4636
Type of Change
Did you update CHANGELOG.md?
Test Plan
Added model tests (integration tests will be added later). CI passes.