Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing AccountRoot fields #399

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Add missing AccountRoot fields #399

merged 3 commits into from
Feb 13, 2023

Conversation

nkramer44
Copy link
Collaborator

Fixes #398 .

I also noticed that AccountSet.mintAccount had an old JSON field value, so I updated that. Also added an IT in NfTokenIT that mints an NFT via an authorized minter.

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #399 (e5384d1) into main (95e7e65) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #399   +/-   ##
=========================================
  Coverage     90.04%   90.04%           
  Complexity     1374     1374           
=========================================
  Files           265      265           
  Lines          3996     3996           
  Branches        332      332           
=========================================
  Hits           3598     3598           
  Misses          278      278           
  Partials        120      120           
Impacted Files Coverage Δ
...rg/xrpl/xrpl4j/model/ledger/AccountRootObject.java 100.00% <ø> (ø)
...org/xrpl/xrpl4j/model/transactions/AccountSet.java 94.87% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nkramer44 nkramer44 merged commit 23885e2 into main Feb 13, 2023
@nkramer44 nkramer44 deleted the nk/398-account-root-fields branch February 13, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing fields to AccountRootObject
2 participants