Add closeDate and closeDateHuman to AccountTransactionsTransaction #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #407 +/- ##
=========================================
Coverage 90.04% 90.05%
- Complexity 1374 1377 +3
=========================================
Files 265 265
Lines 3996 4000 +4
Branches 332 333 +1
=========================================
+ Hits 3598 3602 +4
Misses 278 278
Partials 120 120
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sappenin
requested changes
Feb 21, 2023
...core/src/main/java/org/xrpl/xrpl4j/model/client/accounts/AccountTransactionsTransaction.java
Outdated
Show resolved
Hide resolved
...n/java/org/xrpl/xrpl4j/model/jackson/modules/AccountTransactionsTransactionDeserializer.java
Outdated
Show resolved
Hide resolved
...n/java/org/xrpl/xrpl4j/model/jackson/modules/AccountTransactionsTransactionDeserializer.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/xrpl/xrpl4j/model/client/accounts/AccountTransactionsResultJsonTests.java
Show resolved
Hide resolved
Add test to AccountTransactionsResultJsonTests with minimal JSON.
sappenin
approved these changes
Feb 22, 2023
abhaygupta1999
pushed a commit
to abhaygupta1999/xrpl4j
that referenced
this pull request
Jul 13, 2023
…RPLF#407) * add closeDate and closeDateHuman to AccountTransactionsTransaction * add TimeUtils to encapsulate xrpl timestamp conversion. Add test to AccountTransactionsResultJsonTests with minimal JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #400