-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Transaction Metadata AffectedNodes #429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkramer44
changed the title
[WIP] Add Transaction Metadata AffectedNodes
Add Transaction Metadata AffectedNodes
Jun 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #429 +/- ##
============================================
+ Coverage 90.09% 90.27% +0.18%
- Complexity 1385 1416 +31
============================================
Files 268 276 +8
Lines 4027 4104 +77
Branches 332 339 +7
============================================
+ Hits 3628 3705 +77
Misses 279 279
Partials 120 120
|
Fail CI if codecov upload fails
sappenin
approved these changes
Jun 29, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds object mappings for transaction metadata
AffectedNodes
. EachAffectedNode
is one ofCreatedNode
,ModifiedNode
, orDeletedNode
. Each one of those represents a ledger object in some way -- however, the representation does not always contain all fields of the object. Therefore, I copied all of theLedgerObject
classes and renamed them with aMeta
prefix, and made all of the fieldsOptional
.