Allow for empty transaction flags #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… transaction flags fields to empty flags.
Codecov Report
@@ Coverage Diff @@
## main #434 +/- ##
============================================
+ Coverage 90.27% 90.30% +0.02%
- Complexity 1416 1432 +16
============================================
Files 276 277 +1
Lines 4104 4125 +21
Branches 339 339
============================================
+ Hits 3705 3725 +20
Misses 279 279
- Partials 120 121 +1
|
sappenin
requested changes
Jun 29, 2023
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/flags/NfTokenCreateOfferFlags.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/flags/AccountSetTransactionFlags.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/flags/TransactionFlags.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/flags/TransactionFlags.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/flags/TrustSetFlags.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/test/java/org/xrpl/xrpl4j/codec/binary/BinarySerializationTests.java
Show resolved
Hide resolved
xrpl4j-core/src/test/java/org/xrpl/xrpl4j/crypto/signing/MultiSignedTransactionTest.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/test/java/org/xrpl/xrpl4j/crypto/signing/SignedTransactionTest.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/json/EscrowJsonTests.java
Show resolved
Hide resolved
...-core/src/test/java/org/xrpl/xrpl4j/model/transactions/json/NfTokenCreateOfferJsonTests.java
Show resolved
Hide resolved
…on-zero flags values for transactions that have specific flags.
sappenin
reviewed
Jun 30, 2023
xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/json/PaymentChannelJsonTests.java
Show resolved
Hide resolved
sappenin
reviewed
Jun 30, 2023
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/CheckCash.java
Outdated
Show resolved
Hide resolved
…Derived. Add tests for unset flags, non-zero flags
…lyCanonicalSig int values with TransactionFlags.FULLY_CANONICAL_SIG.getValue()
sappenin
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #425