Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #446 (Consistent secp256k1 Curve) #447

Merged
merged 11 commits into from
Jul 13, 2023
Merged

Fixes #446 (Consistent secp256k1 Curve) #447

merged 11 commits into from
Jul 13, 2023

Conversation

sappenin
Copy link
Collaborator

  • Use BcKeyUtils values everywhere.
  • Deprecate unused interface that is public.

@sappenin sappenin added the bug Something isn't working label Jul 12, 2023
@sappenin sappenin added this to the v3.0 milestone Jul 12, 2023
@sappenin sappenin self-assigned this Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #447 (28eedcf) into main (23831ff) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #447      +/-   ##
============================================
- Coverage     90.54%   90.40%   -0.15%     
+ Complexity     1452     1451       -1     
============================================
  Files           281      281              
  Lines          4147     4147              
  Branches        339      339              
============================================
- Hits           3755     3749       -6     
- Misses          271      277       +6     
  Partials        121      121              
Impacted Files Coverage Δ
...a/org/xrpl/xrpl4j/crypto/signing/bc/Secp256k1.java 0.00% <ø> (-100.00%) ⬇️
...ava/org/xrpl/xrpl4j/crypto/keys/bc/BcKeyUtils.java 83.33% <100.00%> (ø)
...l/xrpl4j/crypto/signing/bc/BcSignatureService.java 96.77% <100.00%> (ø)
.../xrpl/xrpl4j/crypto/signing/bc/EcDsaSignature.java 72.00% <100.00%> (ø)

@sappenin sappenin merged commit 8ae2897 into main Jul 13, 2023
30 of 34 checks passed
@sappenin sappenin deleted the df/fixes-446-secp branch July 13, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants