Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #450
Some of the
amount
fields in NFT related objects were typed asXrpCurrencyAmount
s, when they should have beenCurrencyAmount
. This was noticed because parsing transaction metadata with anAffectedNode
forNFTokenOffer
objects would throw an exception. This is because xrpl4j could not deserialize to aMetaNfTokenOfferObject
because theamount
field could not be deserialized correctly.This PR changes the
amount
field inSellOffer
,BuyOffer
,NfTokenOfferObject
andMetaNfTokenOfferObject
fromXrpCurrencyAmount
toCurrencyAmount
.