Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zero AccountSetFlag #459

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Add Zero AccountSetFlag #459

merged 1 commit into from
Jul 19, 2023

Conversation

nkramer44
Copy link
Collaborator

Ledger 39597277 on testnet contains an AccountSet transaction where ClearFlag is 0. AccountSetFlag does not have an enum value for 0, so the AccountSet transaction failed to get deserialized to an AccountSet xrpl4j object. This PR adds a new AccountSetFlag called NONE that maps to 0.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #459 (591d082) into main (7823236) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #459   +/-   ##
=========================================
  Coverage     90.43%   90.44%           
  Complexity     1464     1464           
=========================================
  Files           285      285           
  Lines          4163     4164    +1     
  Branches        339      339           
=========================================
+ Hits           3765     3766    +1     
  Misses          277      277           
  Partials        121      121           
Impacted Files Coverage Δ
...org/xrpl/xrpl4j/model/transactions/AccountSet.java 95.45% <100.00%> (+0.10%) ⬆️

@nkramer44 nkramer44 merged commit 6da45b8 into main Jul 19, 2023
18 of 19 checks passed
@nkramer44 nkramer44 deleted the nk/zero-accountset-flag branch July 19, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants