Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for No-Op AccountSet SetFlag and ClearFlag values #479

Merged
merged 4 commits into from
Aug 14, 2023

Conversation

nkramer44
Copy link
Collaborator

Fixes #477

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #479 (64bd3be) into main (42047e1) will increase coverage by 0.03%.
The diff coverage is 94.44%.

@@             Coverage Diff              @@
##               main     #479      +/-   ##
============================================
+ Coverage     90.48%   90.52%   +0.03%     
- Complexity     1473     1489      +16     
============================================
  Files           289      289              
  Lines          4184     4220      +36     
  Branches        339      347       +8     
============================================
+ Hits           3786     3820      +34     
  Misses          277      277              
- Partials        121      123       +2     
Files Changed Coverage Δ
...org/xrpl/xrpl4j/model/transactions/AccountSet.java 95.00% <94.44%> (-0.46%) ⬇️

@nkramer44 nkramer44 merged commit 96650dd into main Aug 14, 2023
18 of 19 checks passed
@nkramer44 nkramer44 deleted the nk/477-account-set-flags branch August 14, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LedgerResult Deserialization: AccountSet SetFlag/ClearFlag can be any 32 bit number
2 participants