Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Clawback #485

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Add support for Clawback #485

merged 5 commits into from
Sep 20, 2023

Conversation

nkramer44
Copy link
Collaborator

@nkramer44 nkramer44 commented Sep 19, 2023

Fixes #484

Adds support for the Clawback amendment.

Note: CI build will not pass on testnet until the amendment is enabled. We should not merge this PR until it is enabled on testnet, and maybe not until it is enabled on mainnet (if ever).

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (c0efe11) 90.46% compared to head (bf465d5) 90.50%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #485      +/-   ##
============================================
+ Coverage     90.46%   90.50%   +0.03%     
- Complexity     1499     1504       +5     
============================================
  Files           289      290       +1     
  Lines          4259     4275      +16     
  Branches        351      353       +2     
============================================
+ Hits           3853     3869      +16     
  Misses          281      281              
  Partials        125      125              
Files Changed Coverage Δ
...org/xrpl/xrpl4j/crypto/signing/SignatureUtils.java 99.59% <100.00%> (+0.01%) ⬆️
.../org/xrpl/xrpl4j/model/flags/AccountRootFlags.java 100.00% <100.00%> (ø)
...org/xrpl/xrpl4j/model/transactions/AccountSet.java 95.12% <100.00%> (+0.12%) ⬆️
...a/org/xrpl/xrpl4j/model/transactions/Clawback.java 100.00% <100.00%> (ø)
...rg/xrpl/xrpl4j/model/transactions/Transaction.java 100.00% <100.00%> (ø)
...rpl/xrpl4j/model/transactions/TransactionType.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sappenin sappenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkramer44 nkramer44 merged commit dae2fd6 into main Sep 20, 2023
17 of 19 checks passed
@nkramer44 nkramer44 deleted the nk/clawback branch September 20, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Clawback feature
2 participants