Revert logback-classic to 1.3.X to work with JDK 8 #509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed after dependabot bumped
logback-classic
from 1.3.x to 1.4.x that logging stopped working and I saw this warning:Failed to load class org.slf4j.impl.StaticLoggerBinder
. According to https://www.slf4j.org/codes.html#StaticLoggerBinder, logback-classic 1.4.x targets slf4j v2.x.x, so I tried to bump slf4j to v2.0.9 and logback-classic to 1.4.x. However, logback-classic 1.4.x supports JDK 11 and up, not JDK 8, which we try to support in xrpl4j. Therefore, I downgraded logback-classic to the latest 1.3.x and bumped slf4j to v2.0.7 based on https://logback.qos.ch/download.html