Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert logback-classic to 1.3.X to work with JDK 8 #509

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

nkramer44
Copy link
Collaborator

I noticed after dependabot bumped logback-classic from 1.3.x to 1.4.x that logging stopped working and I saw this warning: Failed to load class org.slf4j.impl.StaticLoggerBinder. According to https://www.slf4j.org/codes.html#StaticLoggerBinder, logback-classic 1.4.x targets slf4j v2.x.x, so I tried to bump slf4j to v2.0.9 and logback-classic to 1.4.x. However, logback-classic 1.4.x supports JDK 11 and up, not JDK 8, which we try to support in xrpl4j. Therefore, I downgraded logback-classic to the latest 1.3.x and bumped slf4j to v2.0.7 based on https://logback.qos.ch/download.html

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24bf996) 91.61% compared to head (aab7856) 91.65%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #509      +/-   ##
============================================
+ Coverage     91.61%   91.65%   +0.04%     
  Complexity     1774     1774              
============================================
  Files           365      365              
  Lines          4948     4948              
  Branches        408      408              
============================================
+ Hits           4533     4535       +2     
+ Misses          282      280       -2     
  Partials        133      133              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sappenin sappenin merged commit 3c4a076 into main Dec 6, 2023
18 of 19 checks passed
@sappenin sappenin deleted the nk/fix-logging branch December 6, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants