Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Issue #49 (Make it easier to get the amount of an XRP payment as BigDecimal) #68

Merged
merged 8 commits into from
Feb 23, 2021
Merged

Fixes Issue #49 (Make it easier to get the amount of an XRP payment as BigDecimal) #68

merged 8 commits into from
Feb 23, 2021

Conversation

sappenin
Copy link
Collaborator

  • Make it easier to get the amout of an XRP Payment as a BigDecimal.
  • Improve the boundary checking of the XrpCurrencyAmount.
  • Add unit test coverage.

Signed-off-by: David Fuelling sappenin@gmail.com

@sappenin
Fixes #49
3166974 
* Make it easier to get the amout of an XRP Payment as a BigDecimal.
* Improve the boundary checking of the XrpCurrencyAmount.
* Add unit test coverage.

Signed-off-by: David Fuelling <sappenin@gmail.com>
sappenin and others added 2 commits February 22, 2021 17:38
@sappenin
Merge branch 'main' into df/fixes-49
e0cc572
@sappenin
Use existing constant
06c7e9a 
Signed-off-by: David Fuelling <sappenin@gmail.com>
@sappenin sappenin mentioned this pull request Feb 23, 2021
Closed
@codecov
Copy link

codecov bot commented Feb 23, 2021 •
edited

Codecov Report

Merging #68 (50f1591) into main (7bfca7d) will decrease coverage by 0.56%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #68      +/-   ##
============================================
- Coverage     82.67%   82.11%   -0.57%     
- Complexity      743      744       +1     
============================================
  Files           179      180       +1     
  Lines          2551     2577      +26     
  Branches        220      225       +5     
============================================
+ Hits           2109     2116       +7     
- Misses          334      352      +18     
- Partials        108      109       +1
Impacted Files Coverage Δ Complexity Δ
...xrpl/xrpl4j/model/transactions/CurrencyAmount.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...rpl4j/model/transactions/IssuedCurrencyAmount.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...va/org/xrpl/xrpl4j/model/transactions/Payment.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...a/org/xrpl/xrpl4j/model/transactions/Wrappers.java 50.00% <61.53%> (+6.52%) 0.00 <0.00> (ø)
.../xrpl/xrpl4j/model/immutables/FluentCompareTo.java 25.00% <0.00%> (ø) 5.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bfca7d...50f1591. Read the comment docs.

@sappenin sappenin changed the title Fixes #49 Fixes Issue #49 (Make it easier to get the amount of an XRP payment as BigDecimal) Feb 23, 2021
@sappenin sappenin added enhancement New feature or request v1.0 labels Feb 23, 2021
@sappenin
Move to handler style for currencies
1dcd61f 
In response to PR comments.

Signed-off-by: David Fuelling <sappenin@gmail.com>
@sappenin sappenin mentioned this pull request Feb 23, 2021
Closed
@sappenin
Make toXrp a class-level method per PR feedback.
195c7a8 
Signed-off-by: David Fuelling <sappenin@gmail.com>
@sappenin
Improve unit test coverage.
22e326b 
Signed-off-by: David Fuelling <sappenin@gmail.com>
@sappenin
Merge branch 'main' of github.com:XRPLF/XRPL4j into df/fixes-49
acf99be 
Signed-off-by: David Fuelling <sappenin@gmail.com>

# Conflicts:
#	xrpl4j-model/src/main/java/org/xrpl/xrpl4j/model/transactions/Wrappers.java
nhartner
nhartner approved these changes Feb 23, 2021
View reviewed changes
Copy link
Collaborator

@nhartner nhartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bueno

@sappenin sappenin merged commit b403348 into main Feb 23, 2021
@sappenin sappenin deleted the df/fixes-49 branch February 23, 2021 22:09
nhartner pushed a commit that referenced this pull request Sep 15, 2021
@sappenin @nhartner
Fixes Issue #49 (Make it easier to get the amount of an XRP payment a…
9bcbab6 
…s BigDecimal) (#68)

* Fixes #49
* Make it easier to get the amount of an XRP Payment as a BigDecimal.
* Improve the boundary checking of `XrpCurrencyAmount`.
* Add unit test coverage.

Signed-off-by: David Fuelling <sappenin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhartner nhartner nhartner approved these changes

@nkramer44 nkramer44 nkramer44 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sappenin @nhartner @nkramer44