Fix canvas utility removed from prefabs unintentionally #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenHodgson
approved these changes
May 3, 2020
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* Only remove utility if answer in dialog is cancel or never * Cleanup namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
Fixes the issue of a
CanvasUtilitybeing removed from a GameObject/Prefab without the user's consent. The utility will only get removed from a game object ifThis "fix" may lead to a
CanvasUtilitystaying on a canvas that was set to Screen Space or modified in a way that it doesn't need a utility anymore. Or XRTK got removed from the scene or something. But that's better than having the user wonder why something stopped working because for some reason the utility got removed from his canvas.