Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added json files to the list of UnityFileExtensions #690

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Added json files to the list of UnityFileExtensions #690

merged 2 commits into from
Nov 23, 2020

Conversation

StephenHodgson
Copy link
Member

@StephenHodgson StephenHodgson added Bug Something isn't working Ready for review PR finished primary development, open for review labels Nov 23, 2020
@StephenHodgson
Copy link
Member Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@StephenHodgson
Copy link
Member Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@StephenHodgson
Copy link
Member Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@StephenHodgson
Copy link
Member Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@SimonDarksideJ
Copy link
Contributor

Thanks @StephenHodgson , this will be very useful for the Steam platform, so long as it is able to return the path to the json files.

@StephenHodgson StephenHodgson merged commit 28a71ec into development Nov 23, 2020
@StephenHodgson StephenHodgson deleted the fix/UnityFileHelper branch November 23, 2020 21:20
XRTK-Build-Bot pushed a commit that referenced this pull request Dec 25, 2020
@StephenHodgson
Added json files to the list of UnityFileExtensions (#690)
f139b34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FejZa FejZa FejZa approved these changes

@SimonDarksideJ SimonDarksideJ Awaiting requested review from SimonDarksideJ

Assignees
No one assigned
Labels
Bug Something isn't working Ready for review PR finished primary development, open for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not all assets are being identified by UnityFileHelper Missing asset files after SDK import via UPM
3 participants
@StephenHodgson @SimonDarksideJ @FejZa