Introduce teleport validation data provider #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 19, 2020
FejZa
added
the
Ready for review
SimonDarksideJ
previously approved these changes
Dec 19, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SimonDarksideJ
approved these changes
Dec 20, 2020
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* Add base setup for MixedRealityTeleportValidationDataProvider * Define IMixedRealityTeleportValidationDataProvider * Refactor TeleportValidationResult * Implement profile and inspector * Implement data provider * Register teleport system data providers properly * Fix profile changes not saved * Remove teleport mode * Update submodules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
This PR introduces the first teleport system data provider. Namingly the
IMixedRealityTeleportValidationDataProviderand its XRTK default implementationMixedRealityTeleportValidationDataProvider.This provider validates teleport targets against a set of rules defined in the
MixedRealityTeleportValidationDataProviderProfile.This logic was so far found mostly in
TeleportPointerand how has found a new home that allows extending rules and configuring them in the profiles.Submodule Changes