Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not override invalid domains #426

Closed
wants to merge 3 commits into from
Closed

fix: do not override invalid domains #426

wants to merge 3 commits into from

Conversation

AkinoKaede
Copy link
Contributor

fix #293

@RPRX
Copy link
Member

RPRX commented Mar 22, 2021

可以写成单独的函数,for+switch

@RPRX
Copy link
Member

RPRX commented Mar 28, 2021

这里可以简化为一个函数:strings.Contains(domain, " "), strings.Contains(domain, "*"), !strings.Contains(domain, ".")

另外 domainsExcluded 为什么会对 mijia cloud 无效?中间有空格的影响是?@chazikai24

@chazikai24
Copy link

这里可以简化为一个函数:strings.Contains(domain, " "), strings.Contains(domain, "*"), !strings.Contains(domain, ".")

另外 domainsExcluded 为什么会对 mijia cloud 无效?中间有空格的影响是?@chazikai24

在luci for v2ray的修改包上填入直连域名mijia cloud,保存之后会自动在中间不上下划线变成mijia_cloud

@chazikai24
Copy link

domainsExcluded

之前开 #293 的时候已经测试过,手动添加之后也不行。有两个米家设备离线。

@RPRX
Copy link
Member

RPRX commented Mar 29, 2021

@AkinoKaede 其实我想的是 range []byte...

@chazikai24 那么这是 GUI 软件的问题,改代码即可,我不认为应该修改 core 的 sniffing 的默认行为,因为这会带来潜在的漏洞

请再次尝试手动改 domainsExcluded,我觉得可能是还有其它域名

@AkinoKaede AkinoKaede closed this Mar 29, 2021
@chazikai24
Copy link

domainsExcluded

继续魔改luci xray插件,修改配置domainsExcluded排除mijia cloud,之后正常了。这个问题luci插件那边估计因为luci交互问题不太好解决。mijia cloud被识别为两个域名,一个mijia一个cloud。总之这个锅不是xray的。问题关闭

@imroc
Copy link
Contributor

imroc commented Oct 25, 2021

看了下最新代码,domainsExcluded 里写小写的 mijia cloud 就可以匹配嗅探到的 yeelight 写死的 Mijia Cloud 域名:

图片

亲测这样配置已解决问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

内置DNS服务器解析一些特殊域名还是存在问题
4 participants