DB(Impala) TIMESTAMP map to datetime with local timezone

XUJiahua · Jul 14, 2020 · 0963f98 · 0963f98
1 parent d82c5b5
commit 0963f98
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/src/metabase/driver/impala.clj b/src/metabase/driver/impala.clj
@@ -262,4 +262,15 @@
   [_ ^ResultSet rs rsmeta ^Integer i]
   (fn []
     (when-let [t (.getTimestamp rs i)]
-      (t/zoned-date-time (t/local-date-time t) (t/zone-id "UTC")))))
+      (t/zoned-date-time (t/local-date-time t)
+                         ;; Impala TIMESTAMP does not have TIMEZONE info.
+                         ;; Usually, We start impalad in local timezone, and store local datetime in Impala
+                         ;;
+                         ;; Meanwhile, metabase expects it has same timezone with database. Refer below:
+                         ;; https://www.metabase.com/docs/latest/troubleshooting-guide/timezones.html
+                         ;; If you’re using a database that doesn’t support a Report Time Zone,
+                         ;; it’s best to ensure that the Metabase instance’s time zone matches
+                         ;; the time zone of the database.
+                         ;;
+                         ;; So it's better get timezone from system, instead of hardcoding "UTC".
+                         (t/zone-id (System/getProperty "user.timezone"))))))