-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
* added logic of apicontroller where the [frombody] #35
Conversation
…t need to be added and fixed bug when i send a object with properties a null in the body
Hi, have you been able to review this pull request? |
Hi, @dadjh85 |
Hi @hbiarge , thanks for the answer, I have updated the pull request to add support to the calls patch, as it was not supported in this nuget until now. And with a simple change we can have support for the api-rest patch calls |
hi @hbiarge, did you get a chance to check the pull request? |
hi @hbiarge, as I've seen that you haven't had time to add features to the library, is it ok if I republish your library through the forked I have in my github and so have the library alive, I currently have the changes in my code repository but it's a shame not to add the improvements because the library is really good. |
let me check @dadjh85 this ASAP! thanks for your patience and sorry for delay |
Hola @dadjh85, |
Vale @Sergio1192 , en tener un tiempo los añado, por otra parte lo he evolucionado un poquito más y lo he migrado a .NET 6 si quieres puedo aportar esa adaptación a esta versión. |
Todo es bienvenido, muchas gracias. Lo único, en PRs separadas para poder llevar un mejor control. |
# Conflicts: # src/Acheve.TestHost/Routing/Tokenizers/ComplexParameterActionTokenizer.cs
Hola @Sergio1192 , ya he actualizado el pull request con los tests, te haré otro con lo que hemos hablado de la migración a .net 6. En caso de aceptar finalmente mi pull request ¿cuando subirás una versión del nuget actualizado? los uso en mis proyectos y para poder utilizar directamente la de nuget.org en vez de usar mi versión muchas gracias un saludo |
Muchas gracias @dadjh85. |
the [apicontroller] attribute makes it unnecessary to add the [frombody] in the actions post, put, etc since by default it looks in the body, to be able to use this nuget forces me to put that attribute when it is not necessary by .NET Core, with this change we can use the apicontroller attribute and get the body object directly without adding the [frombody]. Also I have fixed a little bug that when you fill some object with null property, when it was attached in the body the call fails. can you review @unaizorrilla or @hbiarge or @Xabaril and if it's ok merge this changes in the nuget?