Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* added logic of apicontroller where the [frombody] #35

Merged
merged 5 commits into from
Mar 14, 2022
Merged

* added logic of apicontroller where the [frombody] #35

merged 5 commits into from
Mar 14, 2022

Conversation

dadjh85
Copy link
Contributor

@dadjh85 dadjh85 commented Jul 28, 2020

the [apicontroller] attribute makes it unnecessary to add the [frombody] in the actions post, put, etc since by default it looks in the body, to be able to use this nuget forces me to put that attribute when it is not necessary by .NET Core, with this change we can use the apicontroller attribute and get the body object directly without adding the [frombody]. Also I have fixed a little bug that when you fill some object with null property, when it was attached in the body the call fails. can you review @unaizorrilla or @hbiarge or @Xabaril and if it's ok merge this changes in the nuget?

…t need to be added and fixed bug when i send a object with properties a null in the body
@dadjh85
Copy link
Contributor Author

dadjh85 commented Aug 3, 2020

Hi, have you been able to review this pull request?

@hbiarge
Copy link
Collaborator

hbiarge commented Aug 6, 2020

Hi, @dadjh85
Thanks for your PR!
I´ll review it this weekend, sorry for the delay.

@dadjh85
Copy link
Contributor Author

dadjh85 commented Aug 6, 2020

Hi, @dadjh85
Thanks for your PR!
I´ll review it this weekend, sorry for the delay.

Hi @hbiarge , thanks for the answer, I have updated the pull request to add support to the calls patch, as it was not supported in this nuget until now. And with a simple change we can have support for the api-rest patch calls

@dadjh85
Copy link
Contributor Author

dadjh85 commented Aug 24, 2020

hi @hbiarge, did you get a chance to check the pull request?

@dadjh85
Copy link
Contributor Author

dadjh85 commented Jan 28, 2021

hi @hbiarge, as I've seen that you haven't had time to add features to the library, is it ok if I republish your library through the forked I have in my github and so have the library alive, I currently have the changes in my code repository but it's a shame not to add the improvements because the library is really good.

@unaizorrilla
Copy link
Collaborator

let me check @dadjh85 this ASAP!

thanks for your patience and sorry for delay

@Sergio1192 Sergio1192 changed the base branch from master to develop March 9, 2022 11:22
@Sergio1192 Sergio1192 self-requested a review March 9, 2022 11:22
@Sergio1192
Copy link
Collaborator

Hola @dadjh85,
Se que ha pasado mucho tiempo desde que mis compañeros se pusieron en contacto contigo, pero estamos retomándolo ahora.
Para aceptar la PR, necesitaríamos que añadieras tests de la funcionalidad que aportas y de los bugs que corriges.
Muchas gracias por aportar y siento las molestias y la espera.

@dadjh85
Copy link
Contributor Author

dadjh85 commented Mar 11, 2022

Vale @Sergio1192 , en tener un tiempo los añado, por otra parte lo he evolucionado un poquito más y lo he migrado a .NET 6 si quieres puedo aportar esa adaptación a esta versión.

@Sergio1192
Copy link
Collaborator

Vale @Sergio1192 , en tener un tiempo los añado, por otra parte lo he evolucionado un poquito más y lo he migrado a .NET 6 si quieres puedo aportar esa adaptación a esta versión.

Todo es bienvenido, muchas gracias. Lo único, en PRs separadas para poder llevar un mejor control.
De nuevo, muchas gracias y perdón por tanta espera.

David Jiménez Hernández added 2 commits March 11, 2022 12:24
# Conflicts:
#	src/Acheve.TestHost/Routing/Tokenizers/ComplexParameterActionTokenizer.cs
@dadjh85
Copy link
Contributor Author

dadjh85 commented Mar 11, 2022

Hola @Sergio1192 , ya he actualizado el pull request con los tests, te haré otro con lo que hemos hablado de la migración a .net 6. En caso de aceptar finalmente mi pull request ¿cuando subirás una versión del nuget actualizado? los uso en mis proyectos y para poder utilizar directamente la de nuget.org en vez de usar mi versión muchas gracias un saludo

@Sergio1192
Copy link
Collaborator

Muchas gracias @dadjh85.
Pues en esto de OSS es difícil dar fechas jajajaj espero que, si hay suerte, esta semana podamos subir nueva versión :)

@Sergio1192 Sergio1192 merged commit 15416f1 into Xabaril:develop Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants