Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HealthChecks.Publisher.ApplicationInsights: TelemetryConfiguration.Active is deprecated #348

Closed
chrisketelaar opened this issue Nov 26, 2019 · 1 comment · Fixed by #365
Closed

HealthChecks.Publisher.ApplicationInsights: TelemetryConfiguration.Active is deprecated #348

chrisketelaar opened this issue Nov 26, 2019 · 1 comment · Fixed by #365
Assignees
@unaizorrilla @CarlosLanderas
Labels
enhancement New feature or request

Comments

@chrisketelaar
Copy link

This issue is not to be confused with #186

According to Microsoft to use of TelemetryConfiguration.Active in HealthChecks.Publisher.ApplicationInsights, is deprecated for AspNetCore. Their advise is to use IOptions<TelemetryConfiguration> and get the InstrumentationKey from there.

Link to code:

AspNetCore.Diagnostics.HealthChecks/src/HealthChecks.Publisher.ApplicationInsights/ApplicationInsightsPublisher.cs

Line 116 in e5e0a26

? TelemetryConfiguration.Active

Link to deprecating issue Microsoft:
microsoft/ApplicationInsights-dotnet#1152

I can make a PR for this, but wanted to discuss it first.
@unaizorrilla
Copy link
Collaborator

Hi @chrisketelaar

PR is welcome, thanks!!

@unaizorrilla unaizorrilla added the enhancement New feature or request label Dec 2, 2019
@unaizorrilla unaizorrilla self-assigned this Dec 2, 2019
@CarlosLanderas CarlosLanderas self-assigned this Dec 16, 2019
CarlosLanderas added a commit that referenced this issue Dec 16, 2019
@CarlosLanderas
Fix #348 - Deprecated TelemetryConfiguration.Active
fa3f968
CarlosLanderas added a commit that referenced this issue Dec 16, 2019
@CarlosLanderas
Fix #348 - Deprecated TelemetryConfiguration.Active
07b7bb5
CarlosLanderas added a commit that referenced this issue Dec 16, 2019
@CarlosLanderas
Fix #348 - Deprecated TelemetryConfiguration.Active
ed2946d
CarlosLanderas added a commit that referenced this issue Dec 16, 2019
@CarlosLanderas
Fix #348 - Deprecated TelemetryConfiguration.Active
48840ba
@CarlosLanderas CarlosLanderas mentioned this issue Dec 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unaizorrilla unaizorrilla

@CarlosLanderas CarlosLanderas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@unaizorrilla @chrisketelaar @CarlosLanderas