Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Add support for custom webhooks HttpClient delegating handlers #1046

Merged
merged 3 commits into from
Mar 27, 2022

Conversation

jabadmgm
Copy link
Contributor

@jabadmgm jabadmgm commented Mar 26, 2022

What this PR does / why we need it:
Add support to register custom delegating handlers for webhooks HttpClient to mutate requests.

Which issue(s) this PR fixes: #1023

Does this PR introduce a user-facing change?: No

Sample:

services
    .AddRouting() 
    .AddTransient(sp => new CustomDelegatingHandler(tracer))
    .AddHealthChecksUI(setup =>
    {
        setup.AddHealthCheckEndpoint("endpoint1", "http://healthcheckurl");
        setup.AddWebhookNotification("webhook1", "https://webhookurl", "sample payload");
        setup.UseWebHooksEndpointDelegatingHandler<CustomDelegatingHandler>();
    })
   .AddInMemoryStorage();

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

@jabadmgm
Copy link
Contributor Author

jabadmgm commented Mar 26, 2022

@sungam3r hi, I'm not sure how to do end-to-end testing, still trying to figure it out (if you have time to share some guidance I would be grateful)

@sungam3r
Copy link
Collaborator

@jabadmgm Changes look understandable though I have never used UI bits of this project.

@sungam3r sungam3r merged commit 844aefb into Xabaril:master Mar 27, 2022
@sungam3r sungam3r added UI enhancement New feature or request labels Mar 27, 2022
@jabadmgm
Copy link
Contributor Author

@sungam3r great, thank you! Do you have an estimate for when this feature will be released?

@sungam3r
Copy link
Collaborator

I help to support this project and still have no experience in publishing releases here. ping @carlosrecuero

@jabadmgm
Copy link
Contributor Author

@carlosrecuero additional question: I'm using v5.0.1, will this feature be available in that version?

@carlosrecuero
Copy link
Collaborator

Do you mean v5.0.1 version on HealthChecks or Net (Core)? For new features, we only apply changes into the current version (net6.0). Only some bugs are replicated in previous versions. Sorry for that.

@jabadmgm
Copy link
Contributor Author

jabadmgm commented Apr 4, 2022

@carlosrecuero my project is using .NET5 and library version 5.0.1 (edit: decided to migrate my service to .NET6!)

@jabadmgm
Copy link
Contributor Author

hi @alvarodl, any update on when this might be released? 😊

@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants