Use compatible version of npm #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dockerfile always installs the latest node version, failing the build using the specified Node 8 version. This changes to a npm 5.* version since these version were shipped with Node 8
|
@dasMulli Hi. I help to maintain this repo for some time. I have never used docker or UI stuff from this repo so feedback from core team is required here. Ping @carlosrecuero @unaizorrilla . |
|
@dasMulli Thanks. I tend to merge this since there is no feedback from maintainers and changes look harmless. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dockerfile always installs the latest node version, failing the build using the specified Node 8 version since current versions of npm do not work with Node 8.
This changes to a npm 5.* version since these version were shipped with Node 8
Special notes for your reviewer:
Can a 6.* version be published to dockerhub?
Does this PR introduce a user-facing change?:
No
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Validated that the built container is working using a local docker-compose setup that also worked with the 5.0.0 tag.