Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments and fix build #2114

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Add comments and fix build #2114

merged 1 commit into from
Dec 4, 2023

Conversation

sungam3r
Copy link
Collaborator

@sungam3r sungam3r commented Dec 4, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (81c6697) 64.94% compared to head (ba98fe8) 64.40%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/HealthChecks.System/FileHealthCheck.cs 80.00% 4 Missing and 1 partial ⚠️
src/HealthChecks.System/DiskStorageOptions.cs 71.42% 4 Missing ⚠️
src/HealthChecks.System/FileHealthCheckOptions.cs 60.00% 4 Missing ⚠️
...ncyInjection/SystemHealthCheckBuilderExtensions.cs 87.50% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2114      +/-   ##
==========================================
- Coverage   64.94%   64.40%   -0.55%     
==========================================
  Files         262      248      -14     
  Lines        8496     8363     -133     
  Branches      600      585      -15     
==========================================
- Hits         5518     5386     -132     
- Misses       2828     2830       +2     
+ Partials      150      147       -3     
Flag Coverage Δ
AzureBlobStorage ?
AzureEventHubs ?
AzureFileStorage ?
AzureQueueStorage ?
AzureTableStorage ?
Dapr ?
System 42.56% <76.92%> (+5.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sungam3r sungam3r merged commit 3adb447 into master Dec 4, 2023
3 checks passed
@sungam3r sungam3r deleted the system branch December 4, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants