Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K8s Operator] Add service and deployment annotations to custom resource definition #490

Merged
merged 2 commits into from
Apr 20, 2020

Conversation

CarlosLanderas
Copy link
Contributor

@CarlosLanderas CarlosLanderas commented Apr 20, 2020

What this PR does / why we need it:

Allow the users to deploy healthchecks CRD with custom annotations for target service and deployment.

One clear use case is being able to configure an internal load balancer in Azure Kubernetes Service.

apiVersion: "aspnetcore.ui/v1"
kind: HealthCheck
metadata:
  name: healthchecks-ui
  namespace: lande
spec:
  name: ui-1
  servicesLabel: HealthChecks
  serviceType: LoadBalancer
  serviceAnnotations:
    - name: service.beta.kubernetes.io/azure-load-balancer-internal
      value: "true"
  deploymentAnnotations:
    - name: ServiceType
      value: AksInternalBalancer

Which issue(s) this PR fixes:

Please reference the issue this PR will close: #489

Does this PR introduce a user-facing change?: No

@CarlosLanderas CarlosLanderas merged commit bcc3215 into master Apr 20, 2020
@unaizorrilla unaizorrilla deleted the operator-crd-annotations branch November 22, 2020 16:22
@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[K8s Operator] Allow add annotations to generates deployment and services
1 participant