-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prometheus response writer and publisher #5
Add prometheus response writer and publisher #5
Conversation
Hi @SbiCA I'm sorry for delay on check this PR, I try to review soon |
...ks.Publisher.Prometheus/DependencyInjection/PrometheusGatewayHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
...ks.Publisher.Prometheus/DependencyInjection/PrometheusGatewayHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/HealthChecks.Publisher.Prometheus/PrometheusGatewayPublisher.cs
Outdated
Show resolved
Hide resolved
Hi @SbiCA Looks great in general, please fix minor issues |
No worries, I fixed the things you commented and also adjusted the build.ps1 so we should be able to get a package published let me know if there is anything else left. Cheers |
I try to review this in a few minutes :-) |
thanks @SbiCA Merged and pushed new release tag to create the nuget package. |
Adds support for a prometheus response writer and gateway publisher #4
@unaizorrilla I'm not sure regarding the projects could you please let me know if they are fine.
Cheers