Add prometheus response writer and publisher #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbiCA
changed the title
|
Hi @SbiCA I'm sorry for delay on check this PR, I try to review soon |
...ks.Publisher.Prometheus/DependencyInjection/PrometheusGatewayHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
...ks.Publisher.Prometheus/DependencyInjection/PrometheusGatewayHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/HealthChecks.Publisher.Prometheus/PrometheusGatewayPublisher.cs
Outdated
Show resolved
Hide resolved
|
Hi @SbiCA Looks great in general, please fix minor issues |
|
No worries, I fixed the things you commented and also adjusted the build.ps1 so we should be able to get a package published let me know if there is anything else left. Cheers |
|
I try to review this in a few minutes :-) |
|
thanks @SbiCA Merged and pushed new release tag to create the nuget package. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a prometheus response writer and gateway publisher #4
@unaizorrilla I'm not sure regarding the projects could you please let me know if they are fine.
Cheers