[Network healthcheck] respect timeouts in underlying operations #571 #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosLanderas
commented
Sep 2, 2020
| @@ -25,6 +25,11 @@ public Task<HealthCheckResult> CheckHealthAsync(HealthCheckContext context, Canc | |||
| { | |||
| var connectionInfo = new ConnectionInfo(item.Host, item.Port, item.UserName, item.AuthenticationMethods.ToArray()); | |||
|
|
|||
| if(context.Registration.Timeout > TimeSpan.Zero) | |||
There was a problem hiding this comment.
This healthcheck has no async operation but can use a TimeSpan timeout in the ConnectionInfo class
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: #571
Network healthchecks don't respect timeouts configured in healthchecks registrations
Which issue(s) this PR fixes: #571
Please reference the issue this PR will close: #[issue number]
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Please make sure you've completed the relevant tasks for this PR, out of the following list: