Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emitted TXs: add NetworkID too #259

Open
WietseWind opened this issue Jan 14, 2024 · 2 comments
Open

Emitted TXs: add NetworkID too #259

WietseWind opened this issue Jan 14, 2024 · 2 comments
Labels
feature Feature Request

Comments

@WietseWind
Copy link
Contributor

WietseWind commented Jan 14, 2024

If you look at an emitted TX:
random example:
https://xahauexplorer.com/explorer/6D7A29E3021A3B2425ADC5AF5221D94E7D704DCBD59535D9EEE86A646D3D6D43

... it doesn't contain NetworkID. It obviously doesn't have to but if tools are relying on transactions to have NetworkID to decide how to deal with them when parsing, it would be useful to include it in emitted TXs too.

Workaroudn for now is to decide the CTID and get the NetworkID from there.

image

Alternatively!!

... Serialised tx lacks network ID field: maybe just rely on CTID anyway and decide to ignore this issue :)

@shortthefomo
Copy link

@dangell7 dangell7 added the feature Feature Request label Mar 16, 2024
@RichardAH
Copy link
Contributor

WIP https://github.com/lathanbritz/xahaud/tree/issue/259

Interesting approach but I think it would be better to inject it directly into the actual serialized txn, otherwise you end up with serder issues (the serialized version differs from the deserialized version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature Request
Projects
None yet
Development

No branches or pull requests

4 participants