-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
close_service Function - Slow to Execute #4
Comments
It's possible this is just a limitation SecurID, or something funky with python + ctypes, I skipped execution of everything but what's required to open and close the service and it takes the same amount of time. I wonder if execution time is the same for the v4 and v5 windows client. |
My test run: Win 10 64-bit, Python 3.7.0 32-bit, 1 Token with PIN
|
It's possible this is fixed on the new version. I made lots of changes to the code and the architecture. I don't have a mac to test on , so if you can check it out, feel free. It's now on pypy. |
I can confirm there appears to be a marginal speed improvement of 0.1 seconds, but given the timespan it's possible that's due to external factors. |
The execution time of close_service() is rather long on Mac, On average I'm seeing around 2 seconds to execute.
I've noticed that if I add a breakpoint right before the call to the C API, then wait a few seconds, when I proceed the function executes and finishes very quickly. I'm not sure why this would be the case.
I'd be curious to see how it performs on other people's systems. To that end, I wrote a quick benchmarking script.
Example output:
Edit:
It appears it's a fairly significant portion of the total execution time even on windows, I wonder why that would be.
The text was updated successfully, but these errors were encountered: