Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State preparation ops for tensor network #395

Merged
merged 19 commits into from
Nov 5, 2019
Merged

State preparation ops for tensor network #395

merged 19 commits into from
Nov 5, 2019

Conversation

co9olguy
Copy link
Member

@co9olguy co9olguy commented Nov 2, 2019

Context: The tensor network simulator is currently missing some state preparation ops

Description of the Change: Adding BasisState and QubitStateVector

Benefits: these ops will now be supported

Possible Drawbacks: not sure where in the stack we are checking that state preps happen at the start of the circuit

Related GitHub Issues: #386

@co9olguy co9olguy changed the title State preparation ops for tensor network [WIP] State preparation ops for tensor network Nov 2, 2019
@codecov
Copy link

codecov bot commented Nov 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@cdc3776). Click here to learn what that means.
The diff coverage is 76.47%.

@@            Coverage Diff            @@
##             master     #395   +/-   ##
=========================================
  Coverage          ?   99.39%           
=========================================
  Files             ?       36           
  Lines             ?     2461           
  Branches          ?        0           
=========================================
  Hits              ?     2446           
  Misses            ?       15           
  Partials          ?        0
Impacted Files Coverage Δ
pennylane/plugins/expt_tensornet.py 96.42% <76.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdc3776...b5ff5e0. Read the comment docs.

@co9olguy co9olguy requested a review from josh146 November 2, 2019 19:41
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the plugins check that state preparation is done as a first operation on a device-by-device basis (and some devices don't even check). It would be great to implement the suggestion in #386

pennylane/plugins/expt_tensornet.py Show resolved Hide resolved
pennylane/plugins/expt_tensornet.py Show resolved Hide resolved
@co9olguy co9olguy changed the title [WIP] State preparation ops for tensor network State preparation ops for tensor network Nov 5, 2019
@co9olguy co9olguy merged commit 9b091a9 into master Nov 5, 2019
@josh146 josh146 deleted the tn_state_preps branch December 20, 2019 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants