Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename expt.tensornet device to default.tensor #495

Merged
merged 2 commits into from
Feb 3, 2020

Conversation

josh146
Copy link
Member

@josh146 josh146 commented Feb 2, 2020

Context: The experimental TensorNetwork simulator had a short name that did not fit the PennyLane convention for device shortnames.

Description of the Change:

  • expt.tensornet has become default.tensor

  • expt.tensornet.tf has become default.tensor.tf

Benefits:

  • The expt prefix has been replaced by default, to bring it inline with existing PennyLane simulators.

  • tensornet has been shortened to tensor

Possible Drawbacks: n/a

Related GitHub Issues: n/a

@josh146 josh146 added devices 💻 Device or plugin API related code quality 🎓 Discussion and improvements to code quality review-ready 👌 PRs which are ready for review by someone from the core team. labels Feb 2, 2020
@codecov
Copy link

codecov bot commented Feb 2, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@2096a60). Click here to learn what that means.
The diff coverage is 75%.

@@            Coverage Diff            @@
##             master     #495   +/-   ##
=========================================
  Coverage          ?   99.05%           
=========================================
  Files             ?       73           
  Lines             ?     4457           
  Branches          ?        0           
=========================================
  Hits              ?     4415           
  Misses            ?       42           
  Partials          ?        0
Impacted Files Coverage Δ
pennylane/beta/plugins/__init__.py 100% <100%> (ø)
pennylane/beta/plugins/default_tensor.py 97.68% <66.66%> (ø)
pennylane/beta/plugins/default_tensor_tf.py 92.03% <71.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2096a60...584b0e4. Read the comment docs.

Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Found one other occurrence, other than that it is a thorough renaming :) Would this device still be in an experimental phase, though it's name is changing?

@josh146
Copy link
Member Author

josh146 commented Feb 3, 2020

Yep, I would still consider it experimental as it does not support all the features required of a PennyLane device (i.e. sampling and non analytic mode)

Co-Authored-By: antalszava <antalszava@gmail.com>
@josh146 josh146 merged commit b4fbe0e into master Feb 3, 2020
@josh146 josh146 deleted the rename-default-tensor branch February 3, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality 🎓 Discussion and improvements to code quality devices 💻 Device or plugin API related review-ready 👌 PRs which are ready for review by someone from the core team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants