Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Xastir's probe of ImageMagick to use MagickCore-config if available #147

Closed
tvrusso opened this issue Jul 16, 2019 · 1 comment · Fixed by #149
Closed

Fix Xastir's probe of ImageMagick to use MagickCore-config if available #147

tvrusso opened this issue Jul 16, 2019 · 1 comment · Fixed by #149
Projects
Release 2.2.0

Comments

@tvrusso
Copy link
Member

tvrusso commented Jul 16, 2019 •
edited

Apparently, ImageMagick deprecated the "Magick-config" script we have always used to determine CFLAGS, LDFLAGS, and LIBS for Magick. The one they want us to use is MagickCore-config.

They deprecated this in Magick6, and now Magick7 has Magick-config removed.

https://imagemagick.org/script/porting.php has this pretty clearly explained in the "Deprecated Features Removed" section.

Configure should look for MagickCore-config and use it if it finds it, and only look for Magick-config if that newer one isn't found.

This is preventing us from working with ImageMagick7.
@tvrusso
Copy link
Member Author

tvrusso commented Jul 16, 2019

This is not the only thing that impedes us working with ImageMagick7. We expect to find "magick/api.h" and include it, and ImageMagick7 does not have this file. This suggests a major API breakage and that our Magick support will take a lot more work.

It is still the case that we should probe for MagickCore-config instead of Magick-config, as that latter was already deprecated in ImageMagick6.

@tvrusso tvrusso mentioned this issue Jul 16, 2019
Open
tvrusso added a commit to tvrusso/Xastir that referenced this issue Jul 16, 2019
@tvrusso
Use MagickCore-config if available
1abd0ca 
Since the earth was cooling and Xastir used ImageMagick, we've used
the existence of the script "Magick-config" to conclude whether
ImageMagick was installed or not, and if it was, we used this script
to get Magick to tell us what CFLAGS, LDFLAGS, and LIBS to use to
build with Magick support.

Magick 6 deprecated this script in favor of one called
MagickCore-config.  It works exactly like the older one did and in
ImageMagick 6 returns exactly the same values for all requested flags.

Magick 7 deleted the old script.

We now first look for MagickCore-config and
set MAGIC_BIN to that path if we find it.  If we don't find it, we
look for Magick-config and set MAGIC_BIN to that path if we find it.

This commit closes Xastir#147.

It does not in fact allow Magick 7 to work with Xastir, but that's
another issue (Xastir#148).  This one had to be cleared before we could even
start on the harder one.
@tvrusso tvrusso mentioned this issue Jul 16, 2019
Merged
tvrusso added a commit that referenced this issue Jul 16, 2019
@tvrusso
Merge pull request #149 from tvrusso/issue-147
29443ca 
Use MagickCore-config if available

Closes #147
@tvrusso tvrusso added this to Done in Release 2.2.0 Jul 16, 2019
we7u pushed a commit to we7u/Xastir that referenced this issue Feb 28, 2020
@tvrusso @we7u
Use MagickCore-config if available
02eeb57 
Since the earth was cooling and Xastir used ImageMagick, we've used
the existence of the script "Magick-config" to conclude whether
ImageMagick was installed or not, and if it was, we used this script
to get Magick to tell us what CFLAGS, LDFLAGS, and LIBS to use to
build with Magick support.

Magick 6 deprecated this script in favor of one called
MagickCore-config.  It works exactly like the older one did and in
ImageMagick 6 returns exactly the same values for all requested flags.

Magick 7 deleted the old script.

We now first look for MagickCore-config and
set MAGIC_BIN to that path if we find it.  If we don't find it, we
look for Magick-config and set MAGIC_BIN to that path if we find it.

This commit closes Xastir#147.

It does not in fact allow Magick 7 to work with Xastir, but that's
another issue (Xastir#148).  This one had to be cleared before we could even
start on the harder one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 2.2.0
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use MagickCore-config if available tvrusso/Xastir
1 participant
@tvrusso