Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3D Transforms Pitch & Yaw inverted in Version 0.8.0 #116

Closed
3 tasks done
Xaymar opened this issue Mar 25, 2020 · 1 comment · Fixed by #127
Closed
3 tasks done

3D Transforms Pitch & Yaw inverted in Version 0.8.0 #116

Xaymar opened this issue Mar 25, 2020 · 1 comment · Fixed by #127
Labels
bug Bugs such as crashing, freezing, broken functionality, etc. verified Contents of this Issue were confirmed to happen as described.
Milestone
3D Transform (Com...

Comments

@Xaymar
Copy link
Owner

Xaymar commented Mar 25, 2020

Description

In 0.7.1 and earlier, Pitch and Yaw of 3D Transform was 'correct'. But from version 0.8.0 onward they are inverted for an unknown reason. This breaks the upgrade flow for a stable filter.

Expected Behavior

3D Transform should not suddenly invert after updating StreamFX from 0.7.1 to 0.8.0.

Reproduction Steps

  1. Install StreamFX 0.7.1
  2. Add a 3D Transform filter, Perspective, set Yaw/Pitch to nonzero
  3. Upgrade StreamFX to 0.8.0

System Information

  • Software Version: 0.8.0a3
  • Operating System: Windows
  • Kernel Version: 1998
  • CPU: AMD Ryzen 7 1950X
  • GPU: Nvidia RTX 2080 Ti
  • RAM: 64GB

Checklist:

  • I have read the contribution guidelines.
  • I can reproduce the issue with the exact reproduction steps I have provided.
  • The issue appears on all of my systems that can run this software.
@Xaymar Xaymar added bug Bugs such as crashing, freezing, broken functionality, etc. status:confirmed labels Mar 25, 2020
@Xaymar Xaymar added this to the 0.8.0 milestone Mar 25, 2020
@Xaymar
Copy link
Owner Author

Xaymar commented Mar 28, 2020

Bug was introduced in 0.7.2 in the commit efb6b0b. Since all versions after 0.7.1 have been pre-releases, the behavior for 0.8.0's 3D Transform will revert to that of 0.7.1.

For users of the plugin that are currently using the filter, please make sure to adjust your settings. You should only need to invert the value for pitch and yaw for this to work as expected again.

@Xaymar Xaymar closed this as completed in 18b3cd3 Mar 28, 2020
@Xaymar Xaymar added verified Contents of this Issue were confirmed to happen as described. and removed status:confirmed labels Apr 2, 2020
Xaymar added a commit that referenced this issue Apr 2, 2020
@Xaymar
plugin: Version 0.8.0a4
7e0cc15 
* Updated libOBS to 25.0.3.
* Improved support for Ubuntu 16.04 and 18.04, for both GCC 8 and GCC 9.
* Fixed #116: Regression from 0.7.1 to 0.8.0.
* Fixed transitions not showing up.
* Added Shader Transitions, Shader Sources and Shader Filters.
* Added new example files for the new Shaders integration.
* Added Nvidia Face Tracking filter (requires compatible Nvidia RTX GPU and Nvidia AR SDK Runtime).
@Xaymar Xaymar mentioned this issue Apr 2, 2020
Merged
Xaymar added a commit that referenced this issue Apr 2, 2020
@Xaymar
plugin: Version 0.8.0a4
7fe2474 
* Updated libOBS to 25.0.3.
* Improved support for Ubuntu 16.04 and 18.04, for both GCC 8 and GCC 9.
* Fixed #116: Regression from 0.7.1 to 0.8.0.
* Fixed transitions not showing up.
* Added Shader Transitions, Shader Sources and Shader Filters.
* Added new example files for the new Shaders integration.
* Added Nvidia Face Tracking filter (requires compatible Nvidia RTX GPU and Nvidia AR SDK Runtime).
Xaymar added a commit that referenced this issue Apr 2, 2020
@Xaymar
plugin: Version 0.8.0a4
994215a 
* Updated libOBS to 25.0.3.
* Improved support for Ubuntu 16.04 and 18.04, for both GCC 8 and GCC 9.
* Fixed #116: Regression from 0.7.1 to 0.8.0.
* Fixed transitions not showing up.
* Added Shader Transitions, Shader Sources and Shader Filters.
* Added new example files for the new Shaders integration.
* Added Nvidia Face Tracking filter (requires compatible Nvidia RTX GPU and Nvidia AR SDK Runtime).
Repository owner locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Bugs such as crashing, freezing, broken functionality, etc. verified Contents of this Issue were confirmed to happen as described.
Projects
None yet
Milestone
3D Transform (Component, Filter)
Development

Successfully merging a pull request may close this issue.

plugin: Version 0.8.0a4 Xaymar/obs-StreamFX
1 participant
@Xaymar