Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color Grading's Lift feature is just another Offset #515

Closed
Xaymar opened this issue Apr 14, 2021 · 0 comments · Fixed by #517
Closed

Color Grading's Lift feature is just another Offset #515

Xaymar opened this issue Apr 14, 2021 · 0 comments · Fixed by #517
Assignees
@Xaymar
Labels
bug Bugs such as crashing, freezing, broken functionality, etc.
Milestone
Color Grading (Co...

Comments

@Xaymar
Copy link
Owner

Xaymar commented Apr 14, 2021

Description

The Color Grading filter offers a Lift parameter that incorrectly applies an Offset, instead of being an actual Lift in Color Grading. This results in a worse user experience out of the box.

System Information

  • Software Version: 0.10.0b2 and earlier
  • Operating System: Any
  • Kernel Version: Any
  • CPU: Any
  • GPU: Any
  • RAM: Any
@Xaymar Xaymar added bug Bugs such as crashing, freezing, broken functionality, etc. issue:confirmed labels Apr 14, 2021
@Xaymar Xaymar added this to the 0.10 milestone Apr 14, 2021
@Xaymar Xaymar self-assigned this Apr 14, 2021
Xaymar added a commit that referenced this issue Apr 14, 2021
@Xaymar
filters/color-grading: Fix incorrect Lift logic (#515)
de6ca06
Xaymar added a commit that referenced this issue Apr 14, 2021
@Xaymar
filters/color-grading: Fix incorrect Lift logic (#515)
0903d3e 
Fixes #515
@Xaymar Xaymar mentioned this issue Apr 14, 2021
Merged
@Xaymar Xaymar linked a pull request Apr 14, 2021 that will close this issue
Fix various issues with Shaders #517
Merged
Xaymar added a commit that referenced this issue Apr 14, 2021
@Xaymar
filters/color-grading: Fix incorrect Lift logic (#515)
3b03c09 
Fixes #515
Xaymar added a commit that referenced this issue Apr 14, 2021
@Xaymar
filters/color-grading: Adjust range for Lift and Gain (#515)
18e2b30 
Fixes #515
Xaymar added a commit that referenced this issue Apr 14, 2021
@Xaymar
filters/color-grading: Fix incorrect Lift logic (#515)
36b12d9 
Fixes #515
Xaymar added a commit that referenced this issue Apr 14, 2021
@Xaymar
filters/color-grading: Adjust range for Lift and Gain (#515)
515f9c6 
Fixes #515
Repository owner locked as resolved and limited conversation to collaborators Apr 26, 2021
Xaymar added a commit that referenced this issue Mar 27, 2023
@Xaymar
filters/color-grading: Fix incorrect Lift logic (#515)
fccfbd0 
Fixes #515
Xaymar added a commit that referenced this issue Mar 27, 2023
@Xaymar
filters/color-grading: Adjust range for Lift and Gain (#515)
ce201e5 
Fixes #515
Xaymar added a commit that referenced this issue Mar 28, 2023
@Xaymar
filters/color-grading: Fix incorrect Lift logic (#515)
083ba93 
Fixes #515
Xaymar added a commit that referenced this issue Mar 28, 2023
@Xaymar
filters/color-grading: Adjust range for Lift and Gain (#515)
b324ed2 
Fixes #515
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Xaymar Xaymar

Labels
bug Bugs such as crashing, freezing, broken functionality, etc.
Projects
None yet
Milestone
Color Grading (Component, Filter)
Development

Successfully merging a pull request may close this issue.

Fix various issues with Shaders Xaymar/obs-StreamFX
1 participant
@Xaymar