Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denoise filter causes zooming/transparency issues to applied sources #642

Closed
HunterAP23 opened this issue Oct 4, 2021 · 3 comments · Fixed by #648
Closed

Denoise filter causes zooming/transparency issues to applied sources #642

HunterAP23 opened this issue Oct 4, 2021 · 3 comments · Fixed by #648
Labels
bug Bugs such as crashing, freezing, broken functionality, etc.

Comments

@HunterAP23
Copy link

HunterAP23 commented Oct 4, 2021

Operating System

Windows 10 1903 and higher

OBS Studio Version?

27.1

StreamFX Version

0.11.0a4

OBS Studio Log

https://github.com/Xaymar/obs-StreamFX/files/7276370/2021-10-04.03-02-13.txt

OBS Studio Crash Log

No response

Current Behavior

When using the new Denoise filter, there are a few issues encountered in OBS, such as:

  1. Display Capture, Window Capture, and Game Capture sources are forcibly zoomed into the source's top-left corner. In most situations this simply changes the bounding box of the source to be smaller than the source, meaning that adjusting the transform of the source now makes it appear too big for the canvas.
  2. Video Capture sources are forcibly zoomed in, essentially cropping out the majority of the source. The bounding box issue from the above issue is still present here, but the source is also inexplicably zoomed into the top left corner of the source.
    3. Browser sources lose any transparency they may have. This only applies to browser sources specifically. They do not suffer from any issues mentioned in either of the above issues.

Expected Behavior

Denoising filter should not affect the zoom level, transparency, nor bounding boxes for sources.

Steps to Reproduce the Bug

  1. Add any source to OBS.
  2. Apply the Denoise filter to the source.
  3. The issues immediately arise after the Denoise filter has been added.

Any additional Information we need to know?

Using an EVGA RTX 3090 with driver version 271.68
Tested using both Nvidia Video Effects SDK version 0.6.0 and 0.6.5 (latest).

The log shows a repeating message when using the Denoise filter: [StreamFX] <nvidia::vfx::denoising::denoising> Failed to initialize effect due to error: Error while loading the TRT model but I am not sure if this is related to this specific issue.

@HunterAP23 HunterAP23 added status:help-wanted bug Bugs such as crashing, freezing, broken functionality, etc. labels Oct 4, 2021
@Xaymar
Copy link
Owner

Xaymar commented Oct 4, 2021

  1. (and 2.) sound like issues with async sources. I was fairly sure I copied the correct code over, but it seems I've missed some things and the size of the filter is stuck when applied to those.
  2. Applying denoising on transparency removes transparency, which is expected. At the moment you're seeing the exact output from the denoising network, with no post-processing to restore alpha from the input. Still technically a bug.

@Xaymar
Copy link
Owner

Xaymar commented Oct 5, 2021

@HunterAP23 Do you mind submitting the transparency problem as a separate issue, instead of merging it into this issue?

Xaymar added a commit that referenced this issue Oct 5, 2021
Prevents invalid sizes from being used by the filter, which sometimes happens with Async Sources that aren't quite ready yet.

Fixes: #642
@HunterAP23
Copy link
Author

HunterAP23 commented Oct 5, 2021

Yep, will do
Done in #646

@Xaymar Xaymar linked a pull request Oct 5, 2021 that will close this issue
2 tasks
@Xaymar Xaymar added this to the 0.11 milestone Oct 5, 2021
Xaymar added a commit that referenced this issue Oct 5, 2021
Prevents invalid sizes from being used by the filter, which sometimes happens with Async Sources that aren't quite ready yet.

Fixes: #642
Xaymar added a commit that referenced this issue Mar 27, 2023
Prevents invalid sizes from being used by the filter, which sometimes happens with Async Sources that aren't quite ready yet.

Fixes: #642
Xaymar added a commit that referenced this issue Mar 28, 2023
Prevents invalid sizes from being used by the filter, which sometimes happens with Async Sources that aren't quite ready yet.

Fixes: #642
Xaymar added a commit that referenced this issue Apr 5, 2023
Prevents invalid sizes from being used by the filter, which sometimes happens with Async Sources that aren't quite ready yet.

Fixes: #642
@Xaymar Xaymar added this to the Machine Learning Components milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs such as crashing, freezing, broken functionality, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants