Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Update Third-Party dependencies #1013

Merged
merged 4 commits into from
Jan 11, 2023
Merged

Update Third-Party dependencies #1013

merged 4 commits into from
Jan 11, 2023

Conversation

Xaymar
Copy link
Owner

@Xaymar Xaymar commented Jan 11, 2023

Explain the Pull Request

Updates third party dependencies, which should resolve some runtime issues where the plugin or effects may not load correctly.

Completion Checklist

  • This has been tested on the following platforms:
    • MacOS 10.15
    • MacOS 11
    • MacOS 12
    • Ubuntu 20.04
    • Ubuntu 22.04
    • Windows 10
    • Windows 11
  • The copyright headers and license files have been updated.
  • I will maintain this for the forseeable future, and have added myself to CODEOWNERS.

@Xaymar
Copy link
Owner Author

Xaymar commented Jan 11, 2023

MacOS and Ubuntu appear unaffected by the update, so it's only Windows with the problem.

The repository is still pointing at the previous obs-deps version, resulting in runtime link resolving errors.
@Xaymar
Copy link
Owner Author

Xaymar commented Jan 11, 2023

It appears that the latest version of OBS Studio was built with 2023-01-06, but the repository still links to 2022-11-21: https://github.com/obsproject/obs-studio/blob/47f4c18a95c333e60c488cdb2682b5d202f9d2db/.github/workflows/main.yml#L29 . This is what's causing 29.0.0 to fail to load, but 29.0.0-beta3 to still work as expected.

@Xaymar Xaymar marked this pull request as ready for review January 11, 2023 03:55
@Xaymar Xaymar merged commit 07d4e0a into root Jan 11, 2023
@Xaymar Xaymar deleted the patch/third-party branch January 11, 2023 03:56
@Xaymar Xaymar added this to the 0.12 milestone Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant