This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Improve (and/or fix) MacOS and Ubuntu builds #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaymar
force-pushed
the
patch/build-improvements-and-fixes
branch
from
d57de5a
to
cae7694
Compare
|
Ubuntu failure not caused by PR. External issue. |
Xaymar
force-pushed
the
patch/build-improvements-and-fixes
branch
from
cae7694
to
3fd3071
Compare
Builds on Ubuntu incorrectly used gcc instead of g++ for C++ building, resulting in files that should never have worked. Switching this to g++ should drastically improve the stability of StreamFX on Linux. Also on MacOS we use Homebrew to install the remaining tools, but failed to correctly install a specific version of it. As Homebrew only installs the latest version of a package to the global search path, this adjustment should fix the issue with clang-format. Finally since I was already at it, I added clang-tidy integration and made the clang integration global. This way it does not need to be called on a per-project basis any more.
Xaymar
force-pushed
the
patch/build-improvements-and-fixes
branch
from
3fd3071
to
150751e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the Pull Request
Both MacOS and Ubuntu suffered under "invisible" issues that would rarely occur, with nobody being any wiser. This should adress all the problematic regions.
Completion Checklist
CODEOWNERS.