Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Fix version detection and comparison issue #1045

Merged
merged 2 commits into from
May 14, 2023
Merged

Fix version detection and comparison issue #1045

merged 2 commits into from
May 14, 2023

Conversation

Xaymar
Copy link
Owner

@Xaymar Xaymar commented May 14, 2023

Explain the Pull Request

  • An oversight in how versions were generated resulted in version detection failing unexpectedly.
  • A similar oversight in the comparison code made it so that StreamFX would always claim the current version is older than the remote version.

Completion Checklist

  • This has been tested on the following platforms:
    • MacOS 10.15
    • MacOS 11
    • MacOS 12
    • Ubuntu 20.04
    • Ubuntu 22.04
    • Windows 10
    • Windows 11
  • The copyright headers and license files have been updated.
  • I will maintain this for the forseeable future, and have added myself to CODEOWNERS.

@Xaymar Xaymar merged commit 65c45c4 into root May 14, 2023
8 checks passed
@Xaymar Xaymar deleted the patch/versioning branch May 14, 2023 04:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Xaymar