Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing FFmpeg Encoders #1047

Merged
merged 2 commits into from
May 14, 2023
Merged

Fix missing FFmpeg Encoders #1047

merged 2 commits into from
May 14, 2023

Conversation

Xaymar
Copy link
Collaborator

@Xaymar Xaymar commented May 14, 2023

Explain the Pull Request

We previously used an additional call to register encoders, but forgot to actually call it again after the migration. Should just merge the two into one bit, there's no real downside.

Completion Checklist

  • This has been tested on the following platforms:
    • MacOS 10.15
    • MacOS 11
    • MacOS 12
    • Ubuntu 20.04
    • Ubuntu 22.04
    • Windows 10
    • Windows 11
  • The copyright headers and license files have been updated.
  • I will maintain this for the forseeable future, and have added myself to CODEOWNERS.

@Xaymar
cmake: Set some additional feature defaults
3a33ef3
@Xaymar
code: Fix incorrect behavior for encoder::ffmpeg
361b286 
As we previously relied on an additional function call, we should now merge this call into the constructor.
@Xaymar Xaymar marked this pull request as ready for review May 14, 2023 14:26
@Xaymar Xaymar merged commit 8817248 into root May 14, 2023
@Xaymar Xaymar deleted the patch/encoder-ffmpeg branch May 14, 2023 14:54
@Xaymar Xaymar added this to the FFmpeg Encoders (Component) milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
FFmpeg Encoders (Component)
Development

Successfully merging this pull request may close these issues.
1 participant
@Xaymar