Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Encoder behavior when used with OBS Studio #737

Merged
merged 11 commits into from Dec 3, 2021
Merged

Conversation

Xaymar
Copy link
Owner

@Xaymar Xaymar commented Dec 3, 2021

Explain the Pull Request

  • NVENC (via FFmpeg) can now properly be used for Replay Buffer and sets the requested information during obs_video_encoder_create.
  • NVENC (via FFmpeg) now also respects streaming service limits, which OBS sets in a 2nd call to obs_encoder_update.
  • NVENC (via FFmpeg) now supports dynamic reconfiguration for bitrate.
  • AOM AV1 (direct) no longer sets packet priority and drop priority to negative values when OBS expects positive numbers.
  • FFmpeg Encoders now properly set packet priority and drop priority according to the reported frame type.
  • FFmpeg Encoders now properly migrate settings in OBS Studio via a work-around involving modified_properties2.
  • NVENC (via FFmpeg) no longer constantly attempts to transfer settings from older versions.

Related Issues

Checklist

  • I will become the maintainer for this part of code.
  • I have tested this code on all supported Platforms.

With increasing complexity in video encoders, we end up with complex priority and drop priority structures. While the fields are currently ignored by the default libOBSs output plugins, in the future this might no longer be the case. In any case, the increase in complexity requires us to adjust to it.
We won't allow OBS to override everything, just the bare minimum necessary for Replay Buffer, Dynamic Bitrate and generic Streaming.
@Xaymar Xaymar marked this pull request as ready for review December 3, 2021 08:20
@Xaymar Xaymar merged commit 5364f97 into master Dec 3, 2021
@Xaymar Xaymar deleted the patch/encoders branch December 3, 2021 08:20
@Xaymar Xaymar added this to the FFmpeg Encoders (Component) milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant