This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Remove Auto-Dependency System #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaymar
force-pushed
the
patch/deps
branch
17 times, most recently
from
9050eec
to
ba56dad
Compare
Xaymar
changed the title
Xaymar
force-pushed
the
patch/deps
branch
12 times, most recently
from
d8d162a
to
3c2b022
Compare
Xaymar
force-pushed
the
patch/deps
branch
3 times, most recently
from
f674887
to
13c2498
Compare
Xaymar
force-pushed
the
patch/deps
branch
2 times, most recently
from
9a9ab2d
to
b0992ef
Compare
Closed
Xaymar
force-pushed
the
patch/deps
branch
5 times, most recently
from
2c20a92
to
82bcfa3
Compare
|
Windows with Qt6 only is failing in an unusual manner. Despite both of them running on the same code base, one of them is failing to compile. |
Xaymar
force-pushed
the
patch/deps
branch
3 times, most recently
from
6311574
to
f668678
Compare
|
Will merge this as it is, as I have no idea why the obs framework doesn't include any INTERFACE_INCLUDE_DIRECTORIES. |
While the system helped users get started quickly, it also presented a unique problem by itself. As CMake grew, the code that supported this system became more and more fragile to the point of failing at random, with no indication of why it would fail. Additionally as OBS Studio 28.0 adopted a much nicer system, it is no longer necessary to have this system at all. As an addition to this change, all systems that could rely on FindModules now do so. This drastically reduces the complexity of the CMake system, while allowing significantly more flexibility with what binaries are really being used. In the best case this should allow a prepared user to build StreamFX by itself within seconds.
Note: We define CMAKE_PREFIX_PATH for OBS Studio here, which should normally (https://cmake.org/cmake/help/latest/variable/CMAKE_PREFIX_PATH.html#variable:CMAKE_PREFIX_PATH) be filled by the project itself. This is technically non-standard behavior, and may be remedied in the future by OBS Studio.
In some cases, this include is provided automatically when it shouldn't exist at all. The exact cause is unknown.
For unknown reasons this results in an error only when the project is built within git-bash and with cmake. It does not occur with cmake-gui or VS itself.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the Pull Request
Removes the Auto-Dependency System, as it is horribly broken beyond repair.
Completion Checklist
CODEOWNERS.