This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
#881: Texture inputs to Shaders are unstable #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaymar
force-pushed
the
bug/881-shader-texture-inputs-cause-crashesfreezes
branch
2 times, most recently
from
8e02b57
to
d834654
Compare
Xaymar
force-pushed
the
bug/881-shader-texture-inputs-cause-crashesfreezes
branch
from
d834654
to
e5d3db8
Compare
|
This does not resolve the crash when trying to close the properties window, which appears to be caused by these lines in UI/item-widget-helpers.cpp: https://github.com/obsproject/obs-studio/blob/master/UI/item-widget-helpers.cpp#L42-L43 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the Pull Request
Texture inputs to shaders have become incredibly unstable with later versions, which results in crashes and freezes. As this situation is very much unwanted, this PR should improve the situation massively.
Completion Checklist
CODEOWNERS.