Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Deprecate AOM AV1 encoder #886

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Deprecate AOM AV1 encoder #886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions data/locale/en-US.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ UI.Updater.Menu.Channel.Alpha="Alpha"

# Encoder/AOM-AV1
Encoder.AOM.AV1="AOM AV1 (direct)"
Encoder.AOM.AV1.Deprecated="This encoder is deprecated and will be removed soon. Users are urged to switch to the integrated 'SVT-AV1' or 'AOM AV1' encoder as soon as possible."
Encoder.AOM.AV1.Encoder="Encoder"
Encoder.AOM.AV1.Encoder.Usage="Usage"
Encoder.AOM.AV1.Encoder.Usage.GoodQuality="Good Quality"
Expand Down
12 changes: 12 additions & 0 deletions source/encoders/encoder-aom-av1.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.

//--------------------------------------------------------------------------------//
// THIS FEATURE IS DEPRECATED. SUBMITTED PATCHES WILL BE REJECTED.
//--------------------------------------------------------------------------------//

#include "encoder-aom-av1.hpp"
#include <filesystem>
#include <thread>
Expand All @@ -40,6 +44,7 @@
#define ST_I18N "Encoder.AOM.AV1"

// Preset
#define ST_I18N_DEPRECATED ST_I18N ".Deprecated"
#define ST_I18N_ENCODER ST_I18N ".Encoder"
#define ST_I18N_ENCODER_USAGE ST_I18N_ENCODER ".Usage"
#define ST_I18N_ENCODER_USAGE_GOODQUALITY ST_I18N_ENCODER_USAGE ".GoodQuality"
Expand Down Expand Up @@ -1263,6 +1268,7 @@ aom_av1_factory::aom_av1_factory()
_info.type = obs_encoder_type::OBS_ENCODER_VIDEO;
_info.codec = "av1";
_info.caps = OBS_ENCODER_CAP_DYN_BITRATE;
_info.caps |= OBS_ENCODER_CAP_DEPRECATED;

finish_setup();
}
Expand Down Expand Up @@ -1425,6 +1431,12 @@ obs_properties_t* aom_av1_factory::get_properties2(instance_t* data)
{
obs_properties_t* props = obs_properties_create();

{
auto p = obs_properties_add_text(props, "[[deprecated]]", D_TRANSLATE(ST_I18N_DEPRECATED), OBS_TEXT_INFO);
obs_property_text_set_info_type(p, OBS_TEXT_INFO_WARNING);
obs_property_text_set_info_word_wrap(p, true);
}

#ifdef ENABLE_FRONTEND
{
obs_properties_add_button2(props, S_MANUAL_OPEN, D_TRANSLATE(S_MANUAL_OPEN), aom_av1_factory::on_manual_open,
Expand Down
4 changes: 4 additions & 0 deletions source/encoders/encoder-aom-av1.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.

//--------------------------------------------------------------------------------//
// THIS FEATURE IS DEPRECATED. SUBMITTED PATCHES WILL BE REJECTED.
//--------------------------------------------------------------------------------//

#pragma once
#include "common.hpp"
#include <memory>
Expand Down