Fix a huge number of warnings #893

Xaymar · 2022-08-27T11:25:14Z

Explain the Pull Request

Completion Checklist

I have added myself to the Copyright and License headers and files.
I will maintain this code in the future and have added myself to CODEOWNERS.
I have tested this change on the following platforms:
- MacOS 10.15
- MacOS 11
- MacOS 12
- Ubuntu 20.04
- Ubuntu 22.04
- Windows 10
- Windows 11

These warnings are mostly hints or complete nonsense based on broken parsing. It is easier to disable them than to find a common solution that works on all compilers.

This breaks MSVC and results in leaked exceptions.

This removes the Matroska fix for ProRes content, and upgrades from av_init_packet to av_packet_alloc.

It is not valid to pass std::string_view to snprintf's %s.

The compiler will choose the optimal way automatically, and forcing std::move here actually results in two objects existing side by side, before being "moved" into one.

May need to find a better solution such as disabling all warnings on third party code.

Prevents some out-of-order events from occurring.

Xaymar force-pushed the patch/warnings branch 9 times, most recently from 54d7540 to 04603d5 Compare August 29, 2022 11:54

Xaymar added 7 commits August 29, 2022 16:43

cmake: Enable all warnings

1c51690

cmake: Ignore not-so-useful warnings

ed86b53

These warnings are mostly hints or complete nonsense based on broken parsing. It is easier to disable them than to find a common solution that works on all compilers.

code: Don't use try-catch as function definition

96dbd74

This breaks MSVC and results in leaked exceptions.

encoder/ffmpeg: Drop support for broken FFmpeg versions

aa00c06

This removes the Matroska fix for ProRes content, and upgrades from av_init_packet to av_packet_alloc.

code: Always initialize or cast to correct type

0e49f84

updater: Don't pass unused variables into lambda captures

0460330

code: Always provide a default case for enumerations

54357ac

Xaymar force-pushed the patch/warnings branch 4 times, most recently from ab98008 to 469e53e Compare August 30, 2022 10:33

Xaymar added 7 commits August 30, 2022 13:23

ffmpeg/tools: Revert #836

556e409

It is not valid to pass std::string_view to snprintf's %s.

code: (sn)printf automatically zero-terminates strings

d7d797d

code: Revert #836

c597803

The compiler will choose the optimal way automatically, and forcing std::move here actually results in two objects existing side by side, before being "moved" into one.

code: Ignore warnings from external code

41ff8cb

May need to find a better solution such as disabling all warnings on third party code.

cmake, code: Abuse pre-processor to disable/enable warnings

a521221

code: Fix initialization order for constructors

599919f

Prevents some out-of-order events from occurring.

cmake: Remove pointless floating math contract option

dd82efe

Xaymar force-pushed the patch/warnings branch from 8e91541 to dd82efe Compare August 30, 2022 11:29

ci: Install GLES, EGL and OpenGL development files (Linux)

01c8603

Xaymar marked this pull request as ready for review August 30, 2022 17:58

Xaymar merged commit 1bf1ae1 into master Aug 30, 2022

Xaymar deleted the patch/warnings branch August 30, 2022 17:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix a huge number of warnings #893

Fix a huge number of warnings #893

Xaymar commented Aug 27, 2022

Fix a huge number of warnings #893

Fix a huge number of warnings #893

Conversation

Xaymar commented Aug 27, 2022

Explain the Pull Request

Completion Checklist