-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Improve Windows installer with proper System install location, Current User install method, and better UI #930
Conversation
…tions It is now possible to properly uninstall StreamFX from portable installations, without any registry being necessary.
Also don't append default directory name if possible.
This is not something InnoSetup is designed for, but hey, it does work!
ee8839a
to
2661ec7
Compare
…gramData With OBS Studio 0.15.0 came a better location for plugins to install to, which solves many of the current issues. While this location still requires Administrator rights to write to, it is a much safer location than writing directly into the OBS Studio installation directory.
2661ec7
to
c8ab26f
Compare
Thanks to the PR by @abcdw (obsproject/obs-studio#4067) we can support 'local user' installations. These will allow end users to install StreamFX without requiring Administrator rights, or learning how to use OBS Studio in portable mode.
c8ab26f
to
2d6abee
Compare
@Xaymar My previous method for installing with portable mode was Additionally, I really hate that the uninstaller is now mandatory. I'm not a fan of something portable touching the registry at all. Is there a way to prevent it from being created? |
The portable uninstaller doesn't touch the registry. |
An uninstaller entry is added into the Apps section of my Windows 10 settings, that has to use the registry. |
That is the "Current User" mode, the Portable installation has "CreateUninstallRegKey=not IsPortableMode()" preventing it from creating registry keys, which did work in testing. There shouldn't be a need for portable installations anyway - both the new methods are far preferred ways to keep StreamFX around. |
So what parameter do I use for portable mode using the installer in CLI mode now? |
Cli mode is unsupported, and has never been supported. You can write a PR to make it work again, or start using the GUI. |
Well shit. EDIT: Also, disregard the comment that was below I just deleted, I was thinking of another project. |
According to Stackoverflow it is trivial to support this with an ExpandConstant call. Not sure how true the statement is, but I'll look into it anyway. |
Appreciated! |
Explain the Pull Request
This is a combination of multiple related changes to make one thing better:
%ProgramData%\obs-studio\plugins\
. This change appears to have gone unnoticed entirely, as even @obsproject's own obs-plugintemplate does not use this installation location. Hopefully this change will also silence the random people claiming StreamFX modifies OBS Studio - it never has, and never will.%LocalAppData%\Programs\obs-studio\plugins
which may cause some issues with other plugins already using these environment variables - but we can't support every use case anyway. Plus our location adheres to Microsoft's standards of where user software should go to anyway.Completion Checklist
CODEOWNERS
.