Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS CI #173

Merged
merged 2 commits into from
Sep 26, 2019
Merged

Fix macOS CI #173

merged 2 commits into from
Sep 26, 2019

Conversation

thrimbor
Copy link
Member

The update to LLVM 9 on macOS broke CI. Problem described here.

There are two underlying issues here:

  1. LLVM 9 seems to default to enforcing Safe SEH. It's meant to prevent hijacking of the control flow by overwriting the exception handling record (which resides on the stack) and then triggering an exception. Safe SEH protects against that by checking the handler address in the exception handling record against a list containing all the handlers. nxdk doesn't support Safe SEH (we don't even have normal SEH yet), so my solution is to disable Safe SEH in the linker (which doesn't prevent using or implementing Safe SEH, it only allows the linker to generate images that don't guarantee Safe SEH everywhere).
  2. LLVM 9 crashes on macOS when linking in debug mode. I work around this by removing DEBUG = y from the Makefiles of the few samples that use it. While this fixes CI, this being broken is obviously not a good long-term solution (especially if it's a universal problem and not specific to macOS).

@thrimbor thrimbor mentioned this pull request Sep 26, 2019
@JayFoxRox JayFoxRox merged commit a75692f into XboxDev:master Sep 26, 2019
@thrimbor thrimbor deleted the no_safeseh branch October 2, 2019 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants